stephenc
/
maven-plugin-tools
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

o improved code readingness and javadoc 

git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@628490 13f79535-47bb-0310-9956-ffa450edef68
master
Vincent Siveton 2008-02-17 15:01:23 +00:00
parent 36c8b23cc3
commit 1b9e7ba6f4
1 changed files with 14 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
View File

@ -42,7 +42,7 @@ import java.lang.reflect.AccessibleObject;
/** /**
* TODO: add a way to use the plugin POM for the lookup so that the user doesn't have to provide the a:g:v:goal * TODO: add a way to use the plugin POM for the lookup so that the user doesn't have to provide the a:g:v:goal
* as the role hint for the mojo lookup. * as the role hint for the mojo lookup.
* TODO: standarize the execution of the mojo and looking at the results, but could simply have a template method * TODO: standardize the execution of the mojo and looking at the results, but could simply have a template method
* for verifying the state of the mojo post execution * for verifying the state of the mojo post execution
* TODO: need a way to look at the state of the mojo without adding getters, this could be where we finally specify * TODO: need a way to look at the state of the mojo without adding getters, this could be where we finally specify
* the expressions which extract values from the mojo. * the expressions which extract values from the mojo.
@ -303,7 +303,7 @@ public abstract class AbstractMojoTestCase
} }
/** /**
* convience method to obtain the value of a variable on a mojo that might not have a getter. * Convenience method to obtain the value of a variable on a mojo that might not have a getter.
* *
* NOTE: the caller is responsible for casting to to what the desired type is. * NOTE: the caller is responsible for casting to to what the desired type is.
* *
@ -323,7 +323,7 @@ public abstract class AbstractMojoTestCase
} }
/** /**
* convience method to obtain all variables and values from the mojo (including its superclasses) * Convenience method to obtain all variables and values from the mojo (including its superclasses)
* *
* Note: the values in the map are of type Object so the caller is responsible for casting to desired types. * Note: the values in the map are of type Object so the caller is responsible for casting to desired types.
* *
@ -337,7 +337,7 @@ public abstract class AbstractMojoTestCase
} }
/** /**
* convience method to obtain all variables and values from the mojo (including its superclasses) * Convenience method to obtain all variables and values from the mojo (including its superclasses)
* *
* Note: the values in the map are of type Object so the caller is responsible for casting to desired types. * Note: the values in the map are of type Object so the caller is responsible for casting to desired types.
* *
@ -373,7 +373,8 @@ public abstract class AbstractMojoTestCase
} }
/** /**
* convience method to set values to variables in objects that don't have setters * Convenience method to set values to variables in objects that don't have setters
*
* @param object * @param object
* @param variable * @param variable
* @param value * @param value
@ -417,21 +418,15 @@ public abstract class AbstractMojoTestCase
{ {
throw new Exception( "unable to determine " + element ); throw new Exception( "unable to determine " + element );
} }
else
{
return elementDom.getValue(); return elementDom.getValue();
} }
}
else
{
throw new Exception( "unable to determine " + element ); throw new Exception( "unable to determine " + element );
} }
}
else
{
return elementDom.getValue(); return elementDom.getValue();
} }
}
/** /**
* We should make sure this is called in each method that makes use of the container, * We should make sure this is called in each method that makes use of the container,
@ -448,9 +443,7 @@ public abstract class AbstractMojoTestCase
{ {
return; return;
} }
else
{
throw new Exception( "container is null, make sure super.setUp() is called" ); throw new Exception( "container is null, make sure super.setUp() is called" );
} }
}
} }