stephenc
/
maven-plugin-tools
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

o fixed checkstyle + updated javadoc 

git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@684241 13f79535-47bb-0310-9956-ffa450edef68
master
Vincent Siveton 2008-08-09 12:16:04 +00:00
parent 65a52813c7
commit 5d38c8d3a8
2 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParseException.java
View File

@ -37,9 +37,9 @@ public class PluginMetadataParseException
private final String originalMessage; private final String originalMessage;
/** /**
* @param metadataFile * @param metadataFile could be null
* @param message * @param message could be null
* @param cause * @param cause could be null
*/ */
public PluginMetadataParseException( File metadataFile, String message, Throwable cause ) public PluginMetadataParseException( File metadataFile, String message, Throwable cause )
{ {
@ -50,8 +50,8 @@ public class PluginMetadataParseException
} }
/** /**
* @param metadataFile * @param metadataFile could be null
* @param message * @param message could be null
*/ */
public PluginMetadataParseException( File metadataFile, String message ) public PluginMetadataParseException( File metadataFile, String message )
{ {

16
maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParser.java
View File

@ -44,6 +44,8 @@ import java.util.Set;
*/ */
public class PluginMetadataParser public class PluginMetadataParser
{ {
/** Default implementation path which will be replaced in
* AbstractScriptedMojoDescriptorExtractor#extractMojoDescriptorsFromMetadata(Map, PluginDescriptor) */
public static final String IMPL_BASE_PLACEHOLDER = "<REPLACE-WITH-MOJO-PATH>"; public static final String IMPL_BASE_PLACEHOLDER = "<REPLACE-WITH-MOJO-PATH>";
/** /**
@ -96,6 +98,12 @@ public class PluginMetadataParser
return descriptors; return descriptors;
} }
/**
* @param metadataFile not null
* @param mojo not null
* @return a mojo descriptor instance
* @throws PluginMetadataParseException if any
*/
private MojoDescriptor asDescriptor( File metadataFile, Mojo mojo ) private MojoDescriptor asDescriptor( File metadataFile, Mojo mojo )
throws PluginMetadataParseException throws PluginMetadataParseException
{ {
@ -151,8 +159,8 @@ public class PluginMetadataParser
if ( StringUtils.isEmpty( dParam.getName() ) ) if ( StringUtils.isEmpty( dParam.getName() ) )
{ {
throw new PluginMetadataParseException( metadataFile, "Mojo: \'" + mojo.getGoal() + throw new PluginMetadataParseException( metadataFile, "Mojo: \'" + mojo.getGoal()
"\' has a parameter without either property or name attributes. Please specify one." ); + "\' has a parameter without either property or name attributes. Please specify one." );
} }
dParam.setRequired( param.isRequired() ); dParam.setRequired( param.isRequired() );
@ -165,8 +173,8 @@ public class PluginMetadataParser
catch ( DuplicateParameterException e ) catch ( DuplicateParameterException e )
{ {
throw new PluginMetadataParseException( metadataFile, throw new PluginMetadataParseException( metadataFile,
"Duplicate parameters detected for mojo: " + mojo.getGoal(), "Duplicate parameters detected for mojo: "
e ); + mojo.getGoal(), e );
} }
} }
} }