From 5dd3ecc698e743c905c3c54eebb2d7440c54c691 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Mon, 14 May 2012 16:53:36 +0000 Subject: [PATCH] use StringBuilder rather than StringBuffer git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@1338289 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/maven/plugin/plugin/PluginReport.java | 2 +- .../maven/tools/plugin/generator/GeneratorUtils.java | 8 ++++---- .../src/main/resources/help-class-source.vm | 8 ++++---- .../extractor/java/JavaMojoDescriptorExtractor.java | 2 +- .../maven/tools/plugin/javadoc/AbstractMojoTaglet.java | 8 ++++---- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java b/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java index 5a831b1..c74fd95 100644 --- a/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java +++ b/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java @@ -531,7 +531,7 @@ public class PluginReport text( getBundle( locale ).getString( "report.plugin.usage.intro" ) ); sink.paragraph_(); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append( "" ).append( '\n' ); sb.append( " ..." ).append( '\n' ); sb.append( " " ).append( '\n' ); diff --git a/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java b/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java index be7f274..6592820 100644 --- a/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java +++ b/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java @@ -155,7 +155,7 @@ public final class GeneratorUtils return s; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for ( int i = 0; i < s.length(); i++ ) { char c = s.charAt( i ); @@ -326,7 +326,7 @@ public final class GeneratorUtils return ""; } - final StringBuffer sb = new StringBuffer(); + final StringBuilder sb = new StringBuilder(); HTMLEditorKit.Parser parser = new ParserDelegator(); HTMLEditorKit.ParserCallback htmlCallback = new MojoParserCallback( sb ); @@ -393,12 +393,12 @@ public final class GeneratorUtils /** * The current buffer. */ - private final StringBuffer sb; + private final StringBuilder sb; /** * @param sb not null */ - public MojoParserCallback( StringBuffer sb ) + public MojoParserCallback( StringBuilder sb ) { this.sb = sb; } diff --git a/maven-plugin-tools-generators/src/main/resources/help-class-source.vm b/maven-plugin-tools-generators/src/main/resources/help-class-source.vm index dc0db48..f72363b 100644 --- a/maven-plugin-tools-generators/src/main/resources/help-class-source.vm +++ b/maven-plugin-tools-generators/src/main/resources/help-class-source.vm @@ -125,7 +125,7 @@ public class HelpMojo // FIXME encoding as parameter Xpp3Dom pluginElement = build(); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); /** * org.apache.maven.plugins * maven-plugin-plugin @@ -214,7 +214,7 @@ public class HelpMojo */ private static String repeat( String str, int repeat ) { - StringBuffer buffer = new StringBuffer( repeat * str.length() ); + StringBuilder buffer = new StringBuilder( repeat * str.length() ); for ( int i = 0; i < repeat; i++ ) { @@ -232,7 +232,7 @@ public class HelpMojo * @param description The description, not null. * @param indent The base indentation level of each line, must not be negative. */ - private void append( StringBuffer sb, String description, int indent ) + private void append( StringBuilder sb, String description, int indent ) { for ( Iterator it = toLines( description, indent, indentSize, lineLength ).iterator(); it.hasNext(); ) { @@ -275,7 +275,7 @@ public class HelpMojo private static void toLines( List lines, String line, int indentSize, int lineLength ) { int lineIndent = getIndentLevel( line ); - StringBuffer buf = new StringBuffer( 256 ); + StringBuilder buf = new StringBuilder( 256 ); String[] tokens = line.split( " +" ); for ( int i = 0; i < tokens.length; i++ ) { diff --git a/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java b/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java index 9258c46..8b0d7bb 100644 --- a/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java +++ b/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java @@ -481,7 +481,7 @@ public class JavaMojoDescriptorExtractor } else { - StringBuffer value = new StringBuffer( type.getValue() ); + StringBuilder value = new StringBuilder( type.getValue() ); int remaining = type.getDimensions(); diff --git a/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java b/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java index 6dc4fc2..f6759e4 100644 --- a/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java +++ b/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java @@ -60,7 +60,7 @@ public abstract class AbstractMojoTaglet String tagValue = getTagValue( tag ); MutableAttributeSet tagAttributes = getTagAttributes( tag ); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); appendTag( sb, tag, tagAttributes, tagValue ); @@ -75,7 +75,7 @@ public abstract class AbstractMojoTaglet return null; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for ( int i = 0; i < tags.length; i++ ) { String tagValue = getTagValue( tags[i] ); @@ -218,7 +218,7 @@ public abstract class AbstractMojoTaglet * @param tagAttributes not null * @param tagValue not null */ - private void appendTag( StringBuffer sb, Tag tag, MutableAttributeSet tagAttributes, String tagValue ) + private void appendTag( StringBuilder sb, Tag tag, MutableAttributeSet tagAttributes, String tagValue ) { if ( !hasAnnotationParameters() ) { @@ -343,7 +343,7 @@ public abstract class AbstractMojoTaglet * @param sb not null * @param att not null */ - private static void appendAnnotationParameters( StringBuffer sb, MutableAttributeSet att ) + private static void appendAnnotationParameters( StringBuilder sb, MutableAttributeSet att ) { sb.append( "
" );