stephenc
/
maven-plugin-tools
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[MPLUGIN-319] added references to MNG-6109 bug 

git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@1778718 13f79535-47bb-0310-9956-ffa450edef68
master
Herve Boutemy 2017-01-14 03:54:45 +00:00
parent 49349dee7a
commit 81eb53a1c5
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
View File

@ -197,11 +197,13 @@ public class PluginReport
private RuntimeInformation rtInfo; private RuntimeInformation rtInfo;
/** /**
* By default pluginXml should be read with Maven-3.4.0+ (MNG-6109) * <code>META-INF/maven/plugin.xml</code> should be read with Maven-3.4.0+ to get accurate
* For some integration-tests this is not an issue, they can reduce this spec. * <code>since</code> (MNG-6109).
* For cases where missing <code>since</code> info is not an issue, this version range spec can be changed
* to avoid parsing code once again. (notice: should not mark readonly = true in this case...)
*/ */
@Parameter( readonly = true ) @Parameter( defaultValue = "(3.3.9,)", readonly = true )
private String pluginXmlSpec = "(3.3.9,)"; private String pluginXmlSpec;
/** /**
* {@inheritDoc} * {@inheritDoc}
@ -266,7 +268,11 @@ public class PluginReport
private PluginDescriptor extractPluginDescriptor() private PluginDescriptor extractPluginDescriptor()
throws MavenReportException throws MavenReportException
{ {
if ( usePluginXml() ) if ( !usePluginXml() )
{
getLog().debug( "Running a Maven version with MNG-6109 bug: fall back to mojoScanner to get accurate @since" );
}
else
{ {
PluginDescriptorBuilder builder = new PluginDescriptorBuilder(); PluginDescriptorBuilder builder = new PluginDescriptorBuilder();
try try
@ -338,6 +344,11 @@ public class PluginReport
return pluginDescriptor; return pluginDescriptor;
} }
/**
* Check if META-INF/maven/plugin.xml can be read accurately, or if it will trigger MNG-6109 bug
* @return true if running Maven version is fixed
* @see https://issues.apache.org/jira/browse/MNG-6109
*/
private boolean usePluginXml() private boolean usePluginXml()
{ {
try try