From b7120e30cc32b4b051d95a87d8321a4d8e77d0c1 Mon Sep 17 00:00:00 2001 From: Robert Scholte Date: Sun, 4 Nov 2012 20:38:18 +0000 Subject: [PATCH] String.indexOf(char) is faster than String.indexOf(String). git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@1405630 13f79535-47bb-0310-9956-ffa450edef68 --- .../tools/plugin/generator/PluginDescriptorGenerator.java | 2 +- .../maven/tools/plugin/javadoc/AbstractMojoTaglet.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java b/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java index 47578a3..c6985d1 100644 --- a/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java +++ b/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java @@ -445,7 +445,7 @@ public class PluginDescriptorGenerator String roleHint = null; - int posRoleHintSeparator = role.indexOf( "#" ); + int posRoleHintSeparator = role.indexOf( '#' ); if ( posRoleHintSeparator > 0 ) { roleHint = role.substring( posRoleHintSeparator + 1 ); diff --git a/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java b/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java index f6759e4..1f6eadc 100644 --- a/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java +++ b/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java @@ -149,7 +149,7 @@ public abstract class AbstractMojoTaglet { String nextToken = token.nextToken(); - if ( nextToken.indexOf( "=" ) == -1 ) + if ( nextToken.indexOf( '=' ) == -1 ) { // using pattern: @annotation tagValue = nextToken; @@ -178,7 +178,7 @@ public abstract class AbstractMojoTaglet { String nextToken = token.nextToken(); - if ( nextToken.indexOf( "=" ) == -1 ) + if ( nextToken.indexOf( '=' ) == -1 ) { // using pattern: @annotation continue; @@ -385,7 +385,7 @@ public abstract class AbstractMojoTaglet */ private static List getOnlyValues( String text ) { - if ( text.indexOf( "|" ) == -1 ) + if ( text.indexOf( '|' ) == -1 ) { return Collections.emptyList(); }