From c312cac3bb41808a05c08cf202ef84da171edfae Mon Sep 17 00:00:00 2001 From: Herve Boutemy Date: Tue, 26 Jun 2012 21:36:53 +0000 Subject: [PATCH] code simplification git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@1354250 13f79535-47bb-0310-9956-ffa450edef68 --- .../plugin/generator/PluginHelpGenerator.java | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java b/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java index a153d14..045c058 100644 --- a/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java +++ b/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginHelpGenerator.java @@ -107,20 +107,18 @@ public class PluginHelpGenerator if ( mojoDescriptors != null ) { // Verify that no help goal already exists - for ( MojoDescriptor descriptor : mojoDescriptors ) - { - if ( HELP_GOAL.equals( descriptor.getGoal() ) - && !descriptor.getImplementation().equals( helpImplementation ) ) - { - if ( getLogger().isWarnEnabled() ) - { - getLogger().warn( "\n\nA help goal (" + descriptor.getImplementation() - + ") already exists in this plugin. SKIPPED THE " - + helpImplementation + " GENERATION.\n" ); - } + MojoDescriptor descriptor = pluginDescriptor.getMojo( HELP_GOAL ); - return; + if ( ( descriptor != null ) && !descriptor.getImplementation().equals( helpImplementation ) ) + { + if ( getLogger().isWarnEnabled() ) + { + getLogger().warn( "\n\nA help goal (" + descriptor.getImplementation() + + ") already exists in this plugin. SKIPPED THE " + helpImplementation + + " GENERATION.\n" ); } + + return; } }