From e44bb78affb8d4d7c45f72f5fbab003b116ecadc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guillaume=20Bou=C3=A9?= Date: Sun, 15 Jan 2017 13:08:04 +0000 Subject: [PATCH] [MPLUGIN-290] Version 3.4 fails to parse enums with Regex patterns Already fixed by the upgrade of QDox to 2.0-M5 done in r1778362. Test added to prevent regressions. git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@1778912 13f79535-47bb-0310-9956-ffa450edef68 --- .../JavaMojoDescriptorExtractorTest.java | 8 +++++ .../src/test/resources/MPLUGIN-290/Test.java | 32 ++++++++++++++++++ .../resources/MPLUGIN-290/plugin-expected.xml | 33 +++++++++++++++++++ 3 files changed, 73 insertions(+) create mode 100644 maven-plugin-tools-java/src/test/resources/MPLUGIN-290/Test.java create mode 100644 maven-plugin-tools-java/src/test/resources/MPLUGIN-290/plugin-expected.xml diff --git a/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaMojoDescriptorExtractorTest.java b/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaMojoDescriptorExtractorTest.java index c5a09d5..6989cd7 100644 --- a/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaMojoDescriptorExtractorTest.java +++ b/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaMojoDescriptorExtractorTest.java @@ -249,4 +249,12 @@ public class JavaMojoDescriptorExtractorTest assertNull( results ); } + public void testEnumWithRegexPattern() + throws Exception + { + List results = extract( "MPLUGIN-290" ); + + assertNull( results ); + } + } diff --git a/maven-plugin-tools-java/src/test/resources/MPLUGIN-290/Test.java b/maven-plugin-tools-java/src/test/resources/MPLUGIN-290/Test.java new file mode 100644 index 0000000..3c3b5c6 --- /dev/null +++ b/maven-plugin-tools-java/src/test/resources/MPLUGIN-290/Test.java @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.regex.Pattern; + +public enum Test +{ + + Test( Pattern.compile( "a" ) ); + + private Test( Pattern p ) + { + + } + +} diff --git a/maven-plugin-tools-java/src/test/resources/MPLUGIN-290/plugin-expected.xml b/maven-plugin-tools-java/src/test/resources/MPLUGIN-290/plugin-expected.xml new file mode 100644 index 0000000..4234096 --- /dev/null +++ b/maven-plugin-tools-java/src/test/resources/MPLUGIN-290/plugin-expected.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + test + false + true + + + \ No newline at end of file